Fix vuejs#637 - Don't ignore elements with "is" binding in component-…

…name-in-template-casing (vuejs#644)
armano2 · Nov 11, 2018 · 501a409 · 501a409
1 parent 023121c
commit 501a409
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/rules/component-name-in-template-casing.js b/lib/rules/component-name-in-template-casing.js
@@ -61,7 +61,7 @@ module.exports = {
           return
         }
 
-        if (!utils.isCustomComponent(node)) {
+        if (!utils.isHtmlElementNode(node) || utils.isHtmlWellKnownElementName(node.rawName)) {
           return
         }
 

diff --git a/tests/lib/rules/component-name-in-template-casing.js b/tests/lib/rules/component-name-in-template-casing.js
@@ -27,6 +27,8 @@ tester.run('component-name-in-template-casing', rule, {
     '<template><svg><path/></svg></template>',
     '<template><math><mspace/></math></template>',
     '<template><div><slot></slot></div></template>',
+    '<template><h1>Title</h1></template>',
+    '<template><h1 :is="customTitle">Title</h1></template>',
 
     // kebab-case
     {
@@ -80,6 +82,23 @@ tester.run('component-name-in-template-casing', rule, {
       `,
       errors: ['Component name "the-component" is not PascalCase.']
     },
+    {
+      code: `
+      <template>
+        <the-component :is="componentName">
+          content
+        </the-component>
+      </template>
+      `,
+      output: `
+      <template>
+        <TheComponent :is="componentName">
+          content
+        </TheComponent>
+      </template>
+      `,
+      errors: ['Component name "the-component" is not PascalCase.']
+    },
     {
       code: `
       <template>