Fix an issue with the type of case in the custom file names #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminbro
approved these changes
May 18, 2024
|
🎉 This PR is included in version 8.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
arminbro
reviewed
May 26, 2024
| @@ -65,7 +65,7 @@ function getCustomTemplate(componentName, templatePath) { | |||
|
|
|||
| try { | |||
| const template = readFileSync(templatePath, 'utf8'); | |||
| const filename = path.basename(templatePath).replace('TemplateName', componentName); | |||
| const filename = path.basename(templatePath).replace(/template[|_-]?name/i, componentName); | |||
There was a problem hiding this comment.
@this-is-alkv When I initially reviewed your pull request, I missed the pipe symbol | in your regex search. I'm unsure why you added it, but using a vertical bar (|) in filenames is either restricted or highly discouraged due to its special meaning in command-line interfaces and potential issues with file system compatibility.
I've removed it in the latest version of GRC and just wanted to give you an FYI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File names like template-name, template_name etc. are working fine