Remove legacy Meta, bring Optics KSP #2599

nomisRev · 2021-12-16T17:31:20Z

(Disclaimer: edited by @serras)

This PR cleans the slate for the Meta story:

Completely removes Meta from the repo, everything is now in https://github.com/arrow-kt/arrow-meta.
The Optics plug-in based on KSP now lives in this repo, since it does not use Meta anymore. As a result, a few functions from the arrow-meta-test package have been copied there.
Updates the Kotlin version to 1.6.10 (the latest at this moment), this is required by both the ksp and kotlin-compile-testing packages.

The update of kotlinx-coroutines was tried, but it has been unsuccessful due to breaking changes in version 1.6. This would need further investigation.

serras · 2021-12-16T17:35:12Z

Should we move the Optics KSP module here? It no longer depends on Meta, but the docs here do depend on the plug-in.

nomisRev · 2021-12-16T18:10:37Z

We could move it into the Arrow Optics module yes, it will probably make the most sense to develop the compiler plugin there that. I hope it goes green with the bumped versions 🤞

raulraja · 2021-12-16T18:57:41Z

settings.gradle.kts

@@ -32,12 +32,6 @@ project(":arrow-core-test").projectDir = file("arrow-libs/core/arrow-core-test")
 include("arrow-continuations")
 project(":arrow-continuations").projectDir = file("arrow-libs/core/arrow-continuations")

-include("arrow-meta")


nomisRev · 2021-12-20T13:39:52Z

build.gradle.kts

  )

  dokkaGfmMultiModule { removeChildTasks(undocumentedProjects) }
  dokkaHtmlMultiModule { removeChildTasks(undocumentedProjects) }
  dokkaJekyllMultiModule { removeChildTasks(undocumentedProjects) }
 }
+
+apiValidation {
+  ignoredProjects.addAll(listOf("arrow-optics-ksp", "arrow-optics-test", "arrow-site"))


nomisRev · 2021-12-21T09:39:05Z

@serras IT'S GREEEN!!! 😍 😍 😍

serras · 2021-12-21T09:41:09Z

Finally! I’ll approve it, but I think you and @raulraja should have a look too and merge it if you are OK.

nomisRev · 2021-12-21T09:56:33Z

arrow-libs/core/arrow-core/build.gradle.kts

@@ -14,7 +14,7 @@ kotlin {
      dependencies {
        api(projects.arrowContinuations)
        api(projects.arrowAnnotations)
-        implementation(libs.kotlin.stdlibCommon)
+        api(libs.kotlin.stdlibCommon)


@JavierSegoviaCordoba do you know if this is correct?
Since we expose types from Kotlin Std from public API, it should be marked as api right?

nomisRev

Couple of small left overs we need to clean up.
Thank you for looking into this @serras! This is great 👏 👏 👏 🥳

nomisRev · 2021-12-21T09:57:19Z

arrow-libs/core/arrow-core/src/commonTest/kotlin/arrow/core/EitherTest.kt

@@ -36,7 +36,7 @@ class EitherTest : UnitSpec() {
  init {
    testLaws(
      MonoidLaws.laws(Monoid.either(Monoid.string(), Monoid.int()), ARB),
-      FxLaws.suspended<EitherEffect<String, *>, Either<String, Int>, Int>(
+      /*FxLaws.suspended<EitherEffect<String, *>, Either<String, Int>, Int>(


Can these not be uncommented without failing the build @serras ?

Unfortunately not :(

arrow-libs/optics/arrow-optics/src/commonMain/kotlin/arrow/optics/typeclasses/Cons.kt

arrow-libs/optics/arrow-optics/src/commonMain/kotlin/arrow/optics/typeclasses/Snoc.kt

nomisRev · 2021-12-21T12:00:51Z

arrow-libs/optics/arrow-optics-test/src/commonTest/kotlin/arrow/optics/DSLTest.kt

@@ -0,0 +1,106 @@
+//package arrow.optics.arrow.optics


This file can be deleted, it's duplicated with DSLTest.kt inside arrow-optics/test

nomisRev · 2021-12-21T12:02:30Z

@serras I cannot approve since I originally opened this PR. If we clean up these last leftovers it's ready to merge.

Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>

serras · 2021-12-21T12:54:34Z

There seems to be a flaky test in arrow-fx-stm

nomisRev · 2021-12-21T16:38:31Z

@serras mmm, I saw TMapTest failed for a property that has multiple conflicting keys 🤔
Don't think we should block this PR for it, since it should be unrelated. I retriggered CI.

nomisRev added 5 commits December 1, 2021 19:18

Remove arrow-meta module

0aab23f

Bump to Kotlin 1.6.0

81046ac

Conflict Arrow Optics Plugin, and Arrow Optics module

0e06e9f

Remove docs

d9587f6

WIP

19cb22a

nomisRev requested review from serras, raulraja and JavierSegoviaCordoba December 16, 2021 17:31

Try kspAll

045cf7f

Bump versions

95782d2

nomisRev added 2 commits December 16, 2021 19:18

Rolllback Kotlin bump to match ksp release

71c6e33

Rollback version KotlinX Coroutines

d2e95e5

raulraja approved these changes Dec 16, 2021

View reviewed changes

serras added 5 commits December 20, 2021 13:05

Move KSP plug-in to Arrow (tests still need work)

dfce0d6

Do testing of Optics KSP

a6e0923

Update docs

3ecab61

Fix bug in optics-ksp

5a73973

Do not do API check on internal-facing projects

195d72f

nomisRev commented Dec 20, 2021

View reviewed changes

serras mentioned this pull request Dec 20, 2021

Remove legacy arrow meta #2586

Closed

1 task

serras changed the title ~~Optics ksp & remove legacy meta~~ Remove legacy Meta, bring Optics KSP Dec 20, 2021

serras added 7 commits December 20, 2021 16:38

Add iOS tests to Optics KSP

d4d7121

Missing KSP configuration

2d8ccfa

Add targets programatically (thanks for the tip, @nomisRev !)

4fc1b65

Change cache for Linux

4a8c00a

Move to Kotlin 1.6.10

29477f0

Upgrade more stuff

6e642fb

Go back to corotuines 1.6.0-RC

50ea4df

serras added 4 commits December 20, 2021 21:05

Fix build

ef19cfe

Update coroutines to 1.6.0-RC3 (RC2 does not work)

445a202

Move coroutines back to 1.5.2

05b78ee

Fix compilation problem in test

3ad43e9

serras approved these changes Dec 21, 2021

View reviewed changes

nomisRev commented Dec 21, 2021

View reviewed changes

serras and others added 2 commits December 21, 2021 13:25

Delete unneeded file

398e5a9

Apply suggestions from code review by @nomisRev

747aaba

Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>

Try to fix flaky STM test

e825acc

nomisRev merged commit 9d6adcb into main Dec 22, 2021

nomisRev deleted the sv-optics-ksp branch December 22, 2021 07:54

burningfireplace mentioned this pull request Jan 27, 2022

["BUG"] arrow-optics-ksp-plugin doesn't respect target parameter in @optics annotation #2657

Closed

corlaez mentioned this pull request May 11, 2022

["Request"] Replace std kotlin libraries 'api' dependency for 'implementation' #2720

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove legacy Meta, bring Optics KSP #2599

Remove legacy Meta, bring Optics KSP #2599

nomisRev commented Dec 16, 2021 •

edited by serras

serras commented Dec 16, 2021

nomisRev commented Dec 16, 2021

raulraja Dec 16, 2021

nomisRev Dec 20, 2021

nomisRev commented Dec 21, 2021

serras commented Dec 21, 2021

nomisRev Dec 21, 2021 •

edited

nomisRev left a comment

nomisRev Dec 21, 2021

serras Dec 21, 2021

nomisRev Dec 21, 2021

nomisRev commented Dec 21, 2021

serras commented Dec 21, 2021

nomisRev commented Dec 21, 2021

Remove legacy Meta, bring Optics KSP #2599

Remove legacy Meta, bring Optics KSP #2599

Conversation

nomisRev commented Dec 16, 2021 • edited by serras

serras commented Dec 16, 2021

nomisRev commented Dec 16, 2021

raulraja Dec 16, 2021

Choose a reason for hiding this comment

nomisRev Dec 20, 2021

Choose a reason for hiding this comment

nomisRev commented Dec 21, 2021

serras commented Dec 21, 2021

nomisRev Dec 21, 2021 • edited

Choose a reason for hiding this comment

nomisRev left a comment

Choose a reason for hiding this comment

nomisRev Dec 21, 2021

Choose a reason for hiding this comment

serras Dec 21, 2021

Choose a reason for hiding this comment

nomisRev Dec 21, 2021

Choose a reason for hiding this comment

nomisRev commented Dec 21, 2021

serras commented Dec 21, 2021

nomisRev commented Dec 21, 2021

nomisRev commented Dec 16, 2021 •

edited by serras

nomisRev Dec 21, 2021 •

edited