New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy Meta, bring Optics KSP #2599
Changes from 25 commits
0aab23f
81046ac
0e06e9f
d9587f6
19cb22a
045cf7f
95782d2
71c6e33
d2e95e5
dfce0d6
a6e0923
3ecab61
5a73973
195d72f
d4d7121
2d8ccfa
4fc1b65
4a8c00a
29477f0
6e642fb
50ea4df
ef19cfe
445a202
05b78ee
3ad43e9
398e5a9
747aaba
e825acc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,7 +36,7 @@ class EitherTest : UnitSpec() { | |
init { | ||
testLaws( | ||
MonoidLaws.laws(Monoid.either(Monoid.string(), Monoid.int()), ARB), | ||
FxLaws.suspended<EitherEffect<String, *>, Either<String, Int>, Int>( | ||
/*FxLaws.suspended<EitherEffect<String, *>, Either<String, Int>, Int>( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can these not be uncommented without failing the build @serras ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately not :( |
||
Arb.int().map(::Right), | ||
ARB.map { it }, | ||
Either<String, Int>::equals, | ||
|
@@ -51,7 +51,7 @@ class EitherTest : UnitSpec() { | |
either::eager | ||
) { | ||
it.bind() | ||
} | ||
}*/ | ||
) | ||
|
||
"isLeft should return true if Left and false if Right" { | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JavierSegoviaCordoba do you know if this is correct?
Since we expose types from Kotlin Std from public API, it should be marked as
api
right?