New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optics based on kotlin.reflect #2612
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ca3283f
Optics based on kotlin.reflect
serras 0014fe3
Move to a new package
serras 1923589
Update API files
serras d89fa09
Remove unneeded dependency
serras a8728be
Docs
serras 9a8fab7
Merge branch 'main' into optics-reflection
serras 820743f
Merge branch 'main' into optics-reflection
serras File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| plugins { | ||
| id(libs.plugins.kotlin.multiplatform.get().pluginId) | ||
| alias(libs.plugins.arrowGradleConfig.kotlin) | ||
| alias(libs.plugins.arrowGradleConfig.publish) | ||
| } | ||
|
|
||
| apply(plugin = "io.kotest.multiplatform") | ||
|
|
||
| apply(from = property("TEST_COVERAGE")) | ||
| apply(from = property("ANIMALSNIFFER_MPP")) | ||
|
|
||
| kotlin { | ||
| sourceSets { | ||
| jvmMain { | ||
| dependencies { | ||
| api(projects.arrowCore) | ||
| api(projects.arrowOptics) | ||
| api(libs.kotlin.stdlibCommon) | ||
| implementation(libs.kotlin.stdlibJDK8) | ||
| api(libs.kotlin.reflect) | ||
| } | ||
| } | ||
| jvmTest { | ||
| dependencies { | ||
| implementation(projects.arrowOpticsTest) | ||
| implementation(libs.kotlin.stdlibJDK8) | ||
| implementation(libs.junitJupiterEngine) | ||
| implementation(libs.kotlin.reflect) | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Maven publishing configuration | ||
| pom.name=Arrow Optics for Kotlin Reflection | ||
| # Build configuration | ||
| kapt.incremental.apt=false |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this exposes the API of Kotlin Std, and uses the JDK8 implementation?
I'm still not a 100% sure how this works, and what is the correct config :/
I don't we're doing different things in different modules.. but off-topic for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure 100% either. In any case, I've removed the
apidependency onstdlibCommonand just left theimplementationfor the JDK version.