Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Optics KSP Iso generation #2654

Merged
merged 2 commits into from Jan 25, 2022
Merged

Fix Optics KSP Iso generation #2654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8394992
Use first, .. instead of a,..
nomisRev Jan 25, 2022
9232fea
Merge remote-tracking branch 'origin/main' into sv-fix-iso-letters
i-walker Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 24 additions & 1 deletion ...libs/optics/arrow-optics-ksp-plugin/src/main/kotlin/arrow/optics/plugin/internals/isos.kt
View file
Open in desktop
Expand Up @@ -8,7 +8,30 @@ inline val Target.targetNames

private fun processElement(iso: ADT, target: Target): String {
val foci = target.foci
val letters = ('a'..'v').toList()
val letters = listOf(
"first",
"second",
"third",
"fourth",
"fifth",
"sixth",
"seventh",
"eighth",
"ninth",
"tenth",
"eleventh",
"twelfth",
"thirteenth",
"fourteenth",
"fifteenth",
"sixteenth",
"seventeenth",
"eighteenth",
"nineteenth",
"twentieth",
"twentyFirst",
"twentySecond"
)

fun Focus.format(): String =
"${iso.sourceName}.${paramName.plusIfNotBlank(prefix = "`", postfix = "`")}"
Expand Down