Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix traversal code samples of docs #2719

Merged
merged 4 commits into from May 17, 2022
Merged

Fix traversal code samples of docs #2719

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc67e1e
Fix traversal code samples
beneschwab May 9, 2022
55941f5
Add suggestion
beneschwab May 16, 2022
64afd1a
Merge branch 'main' into main
nomisRev May 16, 2022
26d8e63
Merge branch 'main' into main
i-walker May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions arrow-site/docs/docs/traversal/README.md
View file
Open in desktop
Expand Up @@ -45,8 +45,8 @@ data class Employees(val employees: List<Employee>)
```
```kotlin
val john = Employee("John Doe", Company("Arrow", Address("Functional city", Street(23, "lambda street"))))
val jane = Employee("John Doe", Company("Arrow", Address("Functional city", Street(23, "lambda street"))))
val employees = Employees(listOf(john, jane))
val jane = Employee("Jane Doe", Company("Arrow", Address("Functional city", Street(23, "lambda street"))))
val employeeData = Employees(listOf(john, jane))
```

Without lenses, we could use the `copy` method provided on a `data class` for dealing with immutable structures.
Expand All @@ -72,8 +72,8 @@ What we actually wanted to do here is the following: focus into _every_ employee

```kotlin
val employees: Lens<Employees, List<Employee>> = Lens(
get = { it.company },
set = { employee, company -> employee.copy(company = company) }
get = { it.employees },
set = { employee, employees -> employee.copy(employees = employees) }
)

val everyEmployee = Traversal.list<Employee>()
Expand All @@ -88,7 +88,7 @@ val companyAddress: Lens<Company, Address> = Lens(
set = { company, address -> company.copy(address = address) }
)

val addressStrees: Lens<Address, Street> = Lens(
val addressStreet: Lens<Address, Street> = Lens(
get = { it.street },
set = { address, street -> address.copy(street = street) }
)
Expand All @@ -98,9 +98,9 @@ val streetName: Lens<Street, String> = Lens(
set = { street, name -> street.copy(name = name) }
)

val employeesStreetName: Lens<Employee, String> = employees compose everyEmployee compose employeeCompany compose companyAddress compose addressStrees compose streetName
val employeesStreetName: Traversal<Employees, String> = employees compose everyEmployee compose employeeCompany compose companyAddress compose addressStreet compose streetName

employeesStreetName.modify(employee, String::capitalize)
employeesStreetName.modify(employeeData, String::capitalize)
```

## Composition
Expand Down