New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accumulate function to IorRaise #3409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @sampengilly! Looks great to me 👏 👏
bc81e87
to
ff27c01
Compare
Rebased onto updated main branch |
That was fast @sampengilly 😁 |
I think you need to rerun |
Thankfully there weren't many conflicts, though I see the upstream change was a big one (and was surprised to see the test framework change too). Re-running now, for some reason I thought that manually merging it would be enough |
ff27c01
to
04a9891
Compare
We only changed the runner, sadly. Kotest relies on a compiler plugin, but we wanted to turn Arrow into a testing ground for new targets, and dev/EAP releases. Thanks to changing the framework runner we were able to build against dev, eap, etc version of K2 |
@sampengilly would it be possible for you to rebase this work on the new |
Used to combine errors into the IorRaise state and trigger a Both output in a more convenient way. Previously the only mechanism to do this was to call `bind()` on an `Ior.Both`.
72f6098
to
862f953
Compare
Done :) |
Used to combine errors into the IorRaise state and trigger a Both output in a more convenient way. Previously the only mechanism to do this was to call
bind()
on anIor.Both
.