Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accumulate function to IorRaise #3409

Merged
merged 1 commit into from May 13, 2024

Conversation

sampengilly
Copy link
Contributor

Used to combine errors into the IorRaise state and trigger a Both output in a more convenient way. Previously the only mechanism to do this was to call bind() on an Ior.Both.

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @sampengilly! Looks great to me 👏 👏

@sampengilly
Copy link
Contributor Author

Rebased onto updated main branch

@nomisRev
Copy link
Member

That was fast @sampengilly 😁

@nomisRev
Copy link
Member

I think you need to rerun ./gradlew apiDump. Sadly the action to do it automatically doesn't work on forks.

@sampengilly
Copy link
Contributor Author

Thankfully there weren't many conflicts, though I see the upstream change was a big one (and was surprised to see the test framework change too).

Re-running now, for some reason I thought that manually merging it would be enough

@nomisRev
Copy link
Member

(and was surprised to see the test framework change too).

We only changed the runner, sadly. Kotest relies on a compiler plugin, but we wanted to turn Arrow into a testing ground for new targets, and dev/EAP releases. Thanks to changing the framework runner we were able to build against dev, eap, etc version of K2 ☺️

@nomisRev nomisRev requested review from serras and kyay10 April 24, 2024 14:11
@serras
Copy link
Member

serras commented May 12, 2024

@sampengilly would it be possible for you to rebase this work on the new main? This would help us a lot in getting this merged. Thanks in advance!

Used to combine errors into the IorRaise state and trigger
a Both output in a more convenient way. Previously the
only mechanism to do this was to call `bind()` on an `Ior.Both`.
@sampengilly
Copy link
Contributor Author

Done :)

@serras serras merged commit b08c0ac into arrow-kt:main May 13, 2024
11 checks passed
@sampengilly sampengilly deleted the sampengilly/ior-accumulate branch May 14, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants