Try docs #458
Try docs #458
Conversation
There was a problem hiding this comment.
@ahdezma excellent and great work! Let's remove the exception throwing example before we merge and add an example that uses Try.monadError().bindingE where an exception is thrown by a call in the comprehension and you can see that it automatically lifts the exception to the context of Try thanks to bindingE
| ## Try | ||
| ## Try | ||
|
|
||
| Kategory has a lots of different types of error handling and reporting, which can make it difficult to decide which one is best for your situation. |
There was a problem hiding this comment.
Link to http://kategory.io/docs/patterns/error_handling/ for disambiguation on when to use each strategy
| throw AuthorizationException() | ||
| } | ||
|
|
||
| fun getLotteryNumbersFromCloud(): List<User> { |
There was a problem hiding this comment.
Would getUsers be a more appropriate name here?
| ```kotlin:ank | ||
| lotteryTry.recover { | ||
| if (it is NoConnectionException) emptyList() | ||
| else throw it |
There was a problem hiding this comment.
this is not a good example because it promotes exception throwing. We should instead here return another Try or use recoverWith
There was a problem hiding this comment.
or coalesce to a List regardless of the exception type
| } | ||
| ``` | ||
|
|
||
| Or if you have another different computation that can also fail, you can use `recoverWith` to recover from an error (as you do with `recover`, but in this case, returning a new `Try`): |
There was a problem hiding this comment.
This is the actual example we need recoverWith
There was a problem hiding this comment.
I didn't understand the request here :)
|
|
||
| [`Functor`]({{ '/docs/typeclasses/functor/' | relative_url }}) | ||
|
|
||
| Transforming the value, if the computation is a success |
There was a problem hiding this comment.
Very minor, but for consistancy this heading, Computing over independent values, andComputing over dependent values ignoring failure should end in a colon. e.g. Transforming the value, if the computation is a success:
There was a problem hiding this comment.
2574a1a Thanks :)
| ## Try | ||
| ## Try | ||
|
|
||
| Kategory has a [lots of different types of error handling and reporting](http://kategory.io/docs/patterns/error_handling/), which can make it difficult to decide which one is best for your situation. |
There was a problem hiding this comment.
Replace: which can make it difficult to decide which one is best for your situation
For: which allows you to choose the best strategy for your situation
|
|
||
| Computing over dependent values ignoring failure: | ||
|
|
||
| ```kotlin:ank |
There was a problem hiding this comment.
These next 2 blocks will never complete in ank because the interpreter isn't ready for coroutines yet. Please revert them to regular kotlin blocks and hardcode the result.
|
|
||
| Computing over dependent values that are automatically lifted to the context of `Try`: | ||
|
|
||
| ```kotlin:ank |
There was a problem hiding this comment.
Same here, binding is not possible.
|
|
||
| The following example represents the typical case when consuming Java code, where domain errors are represented with exceptions. | ||
|
|
||
| ```kotlin:ank |
There was a problem hiding this comment.
Add silent to this block to avoid getting a blank return
|
No need to actually remove the comprehensions just remove |
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
=========================================
Coverage ? 35.98%
Complexity ? 331
=========================================
Files ? 184
Lines ? 5019
Branches ? 547
=========================================
Hits ? 1806
Misses ? 3052
Partials ? 161
Continue to review full report at Codecov.
|
No description provided.