Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base_dir updating for nested .xsd dependencies #529

Open
wants to merge 1 commit into
base: 2_12
Choose a base branch
from

Conversation

deelin
Copy link

@deelin deelin commented Mar 9, 2017

Say we have the directory structure as follows:

/BASE.xsd --> Depends on deps/Dep1.xsd
/deps/Dep1.xsd --> Depends on Dep2.xsd
/deps/Dep2.xsd

Parsing BASE.xsd from within its containing folder would result in base_dir being . for all nested folders within. So when ./deps/Dep1.xsd is parsed, it will be unable to find Dep2.xsd because it will look in the parent directory . instead of ./deps

@plq
Copy link
Member

plq commented Mar 12, 2017

I was not aware of this behaviour. Can you please also write a test for it?

@plq
Copy link
Member

plq commented Mar 12, 2017

BTW, thanks a lot for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants