Fix string type issues with SOAP/Twisted #685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
plq
reviewed
May 10, 2022
plq
reviewed
May 10, 2022
| @@ -183,7 +183,7 @@ def _reconstruct_url(request): | |||
| url_scheme = 'http' | |||
|
|
|||
| uri = _decode_path(request.uri) | |||
| return ''.join([url_scheme, "://", server_name, uri]) | |||
| return ''.join([url_scheme, "://", server_name, uri.decode('utf-8')]) | |||
There was a problem hiding this comment.
How do we know that uri is encoded with utf-8 here?
There was a problem hiding this comment.
I thought it was assumed as we create a "context" with utf-8 content type at line 676, but it concerns more the content than the headers.
The standard doesn't seem to allow other chars than ascii in URI during transmission, maybe it's better to decode as ascii rather than utf-8
plq
reviewed
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some issues found when trying to use Twisted with SOAP protocol in Python3