Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model: handle copying embedded model collections #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

model: handle copying embedded model collections #322

wants to merge 1 commit into from
+48 −5

Conversation

bartoszflis-silvair
Copy link

Fixes #321.

@bartoszflis-silvair bartoszflis-silvair force-pushed the embedded-model-collections-deep-copy branch from e114afd to 9fa6897 Compare January 17, 2023 08:29
@bartoszflis-silvair
model: handle copying embedded model collections
426f9a3 
Find all instances of _BaseODMModel subclasses, including those stored
in lists or tuples, and set the required attribute on them during copy.

Fixes art049#321.
@bartoszflis-silvair bartoszflis-silvair force-pushed the embedded-model-collections-deep-copy branch from 9fa6897 to 426f9a3 Compare January 18, 2023 07:18
@art049 art049 force-pushed the master branch 2 times, most recently from 5bd1656 to a99a258 Compare November 3, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michallowasrzechonek-silvair michallowasrzechonek-silvair michallowasrzechonek-silvair left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't change a field in a copied embedded model that's part of a collection #228
2 participants
@bartoszflis-silvair @michallowasrzechonek-silvair