Skip to content
This repository has been archived by the owner on Dec 26, 2023. It is now read-only.

Icons not added to manifest if inject=false #102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Icons not added to manifest if inject=false #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e16d885
add prepare to package.json to allow referencing from github
FlorianBruckner Jun 21, 2019
38bf378
icons are not put into the manifest if "inject=false". This is due to…
FlorianBruckner Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
],
"scripts": {
"build": "babel src --out-dir dist",
"prepare": "npm run build",
"clean": "rimraf -rf tests/*/output && rimraf -rf dist",
"test": "npm run clean && npm run build && node tests/index.js",
"test:debug": "npm run clean && npm run build && node --inspect-brk ./tests/index.js"
Expand Down
2 changes: 1 addition & 1 deletion src/injector/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ function manifest (options, publicPath, icons, callback) {
}

export function buildResources (_this, publicPath, callback) {
if (_this.assets && _this.options.inject) { // already cached and ready to inject
if (_this.assets) { // already cached and ready to inject
callback()
} else {
publicPath = publicPath || ''
Expand Down