Skip to content
This repository has been archived by the owner on Dec 26, 2023. It is now read-only.

refactor(jimp): update jimp to fix minimist vulnerability #122

Closed
wants to merge 1 commit into from

Conversation

Den-dp
Copy link

@Den-dp Den-dp commented Mar 24, 2020

closes #121

package.json Outdated Show resolved Hide resolved
@hc-12
Copy link

hc-12 commented Apr 27, 2020

Can we merge this PR?

@rajatb-git
Copy link

Been waiting for this fix... when will this be merged?

@Den-dp
Copy link
Author

Den-dp commented May 12, 2020

It would be nice if @arthurbergmz or @doug-wade looked at this PR.

But I would say that we are blocked with #119 🤷‍♂️

@bcanseco
Copy link

Checked out @Den-dp's fork - all tests passed. Used it in one of my projects and images are processed as expected. Bumping for a wishful merge 🙏

@Den-dp
Copy link
Author

Den-dp commented Jun 4, 2020

I decided to go with publishing this fix from my own fork. For that I want to configure npm publishing from a master branch (b/c this is how semantic-release package works), but unfortunately this PR was provided via master branch too 🤦.
So have to close it on order to add some configuration for publishing.

@Den-dp Den-dp closed this Jun 4, 2020
@bcanseco
Copy link

bcanseco commented Jun 4, 2020

@Den-dp Please link the npm package once it's published, I'd be interested in using it too 👍

@Den-dp
Copy link
Author

Den-dp commented Jun 4, 2020

So I released a fix from my fork https://github.com/Den-dp/webpack-pwa-manifest/releases/tag/v4.2.1 🙌

https://www.npmjs.com/package/webpack-pwa-manifest-contrib

You can install it via:

npm i webpack-pwa-manifest-contrib@4.2.1 -D

Please notice the new name with -contrib at the end, and make sure to change require('webpack-pwa-manifest-contrib') in webpack.config.js.

@Stanzilla
Copy link
Contributor

@Den-dp nice! are you planning to integrate more of the open pull requests from here? maybe try posting in #119 as well so @arthurbergmz could give you permissions on here?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use latest jimp to fix minimist security vulnerability
6 participants