New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datepicker): showCalendar no longer triggers if readOnly is true #42
Conversation
This pull request is automatically deployed with Now. |
Hi @benhancockco, thanks for contributing to the project. Even though it appears you have fixed the problem, the TravisCI is failing, therefore, I can't merge it. Can you take a look at it, please? |
It looks like the failing pipeline is unrelated to this change. After a bit of digging, it looks like there was an issue with ESLint and object destructuring (eslint/eslint#12335). Upgrading kcd-scripts to 1.8.0 seems to resolve the issue. I'll create a new PR to update the dependencies. |
@benhancockco, since I've merged #43, can you rebase and update this PR so that the build will run again and we check if it passes now? |
3ad6069
to
d25f02e
Compare
Looks like we're good to go! |
🎉 This PR is included in version 1.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for helping on this, @benhancockco. Just so you know, in case you're thinking about working on any other issues, I'm working on a new branch called You can checkout to the branch and take a look at it if you want to, make suggestions, etc. Best regards! 👋 |
originally fixed by @benhancockco on #42
@all-contributors please add @benhancockco for code. |
I've put up a pull request to add @benhancockco! 🎉 |
This PR is a bug fix for issue #41. It ensures the date picker is not shown if the field is marked as
readOnly
.What kind of change does this PR introduce?
It ensures the date picker is not shown if the field is marked as
readOnly
.What is the current behavior?
Currently, when clicking on an input marked as
readOnly
, the date picker will still be displayed.What is the new behavior?
Now, when clicking on an input marked as
readOnly
, the date picker will no longer be displayed.Checklist: