issues#176 fix and minor improvements #786
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 22, 2022 19:48
|
Hi! I appreciate the interest but the proposed changes have the same issue pointed on previous attempts: |
|
Hi, thanks for the answer. I have rewrote logic of localization import, maybe branch is ready for merging now. This branch have breaking changes now, so users to have change code after updating package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
#176
What is the current behavior?
Tests with errors. Locale cant be changed in ESM project. Deprecated addon in storybook.
What is the new behavior?
Tests ok. Locale ok. Replaced addon for actual.
Checklist:
If there are any questions you can text me any time here https://t.me/crazynike94