Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): expose dirname utility to test scripts #2614

Conversation

bernardobridge
Copy link
Contributor

Description

This will be useful when it's necessary to reference a path in the test config, but it's not one we know to resolve automatically (e.g. processors and payloads).

One known use case right now is the Playwright Engine's storageState. Our current example to reuse authentication by leveraging storageState is broken, and this is one way to fix it.

Note: I first cleaned up existing logic a little bit (9da818a), so best to review commit by commit.

Testing

I intend to add an automated test, but didn't have time yet. I've tested manually against Fargate and locally (using the example), and it works.

@bernardobridge bernardobridge marked this pull request as draft April 15, 2024 13:56
@bernardobridge bernardobridge force-pushed the bernardobridge/art-1727-introduce-dirname-construct-to-config-yamls-so-paths-can-be branch from ca3b098 to 890b323 Compare May 13, 2024 10:44
@bernardobridge bernardobridge marked this pull request as ready for review May 13, 2024 11:12
@bernardobridge bernardobridge requested a review from a team May 13, 2024 11:12
@bernardobridge bernardobridge force-pushed the bernardobridge/art-1727-introduce-dirname-construct-to-config-yamls-so-paths-can-be branch from 890b323 to 350cc71 Compare May 13, 2024 16:53
@bernardobridge bernardobridge merged commit fa6acff into main May 13, 2024
22 checks passed
@bernardobridge bernardobridge deleted the bernardobridge/art-1727-introduce-dirname-construct-to-config-yamls-so-paths-can-be branch May 13, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant