build(releases): automate next version increment #10213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: prepare for next release --no-verify chore: prepare for next release --no-verify chore: prepare for next release --no-verify chore: prepare for next release --no-verify
brainbicycle
force-pushed
the
brian/automate-next-version
branch
from
301fc9e
to
9d1ff54
Compare
brainbicycle
commented
May 8, 2024
brainbicycle
commented
May 8, 2024
brainbicycle
requested review from
MounirDhahri,
MrSltun,
araujobarret and
damassi
damassi
reviewed
May 8, 2024
damassi
reviewed
May 8, 2024
damassi
previously approved these changes
May 8, 2024
brainbicycle
commented
May 8, 2024
| puts "Parent latest version: #{parent_version_name}" | ||
| puts "iOS latest version: #{ios_build_number}" | ||
| puts "Android latest version: #{android_build_number}" | ||
| end |
There was a problem hiding this comment.
moved to utils file
damassi
previously approved these changes
May 8, 2024
brainbicycle
commented
May 8, 2024
| MSG | ||
| slack(message: message, default_payloads: [], link_names: true) | ||
| end | ||
| end |
There was a problem hiding this comment.
this method is the meat of it:
if live app and no editable app (the next version to go out):
- create a new version in app store connect
- update the app.json with the new version
- open a pr to update in main
- send a slack message to remind us to merge the pr
else:
- if editable app
- we are good to go
- else
- send a slack message that we need an edit version and it couldn't be created for some reason
MrSltun
previously approved these changes
May 8, 2024
fastlane/Fastfile
Outdated
Comment on lines
199
to
202
| :x: :iphone: | ||
| It's time to update the app version number! | ||
| Merge this pr to keep shipping betas: | ||
| #{pr_url} |
brainbicycle
commented
May 8, 2024
|
|
||
| macos: | ||
| xcode: 15.1 | ||
| resource_class: macos.m1.medium.gen1 |
There was a problem hiding this comment.
since we need to use fastlane here had to update the executor
brainbicycle
commented
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves PHIRE-875
Description
Attempts to automate the step to create the next version of the app.
As part of the nightly beta job check if there is an app version 'Ready for Sale' but not an app version in 'Prepare for Submission'. This should be the state after an app is approved by apple for distribution but we have not yet created the next version for development. If so create a new version.
Note on testing!
Because this depends on our app not having an editable version ready I could only test the individual parts of this. I tried to be thorough but the last bit, actually creating the next version via fastlane, I think we just have to see the next time we release if it works.
PR Checklist
To the reviewers 馃憖
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.