feat: pass e2e unleash experiments as a header to Metaphysics #13557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, I do not see "X-Variants" header until I log in |
joeyAghion
approved these changes
Mar 1, 2024
| Object.entries(featureFlags).filter( | ||
| ([key, value]) => key.startsWith("e2e_") && value.flagEnabled | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Despite what we proposed in the tech plan, this recommends hyphenating feature names so maybe we should align with that.
|
Logged out, I saw a partial But I didn't see the header added to later requests when I navigated around (client-side). After logging in, I seemed to see the full list on all requests: |
|
Sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Feat
Description
This PR is a proof-of-concept and one of a few moving parts for the "Share split-test assignments with back-ends, for safer data/API roll-outs" technical plan.
The idea is that Force and Eigen detect e2e experiments (by "e2e_" prefix in their name) and sends such experiments in "X-Variants" header to Metaphysics.
For demo and testing purposes, I've created two Unleash experiments, they are enabled for dev/staging:
You can test it in action in the review app.