[PURCHASE-2004] Adjust breakpoints for tablet experience #5969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpotts244
force-pushed
the
sizing-updates
branch
2 times, most recently
from
a4b0053
to
97708e9
Compare
Duplicate Sources / Packages - Duplicates found!
|
jpotts244
force-pushed
the
sizing-updates
branch
from
97708e9
to
1aae866
Compare
jpotts244
changed the title
jpotts244
commented
Jul 21, 2020
| @@ -219,7 +219,7 @@ const Conversation: React.FC<ConversationProps> = props => { | |||
| <NoScrollFlex flexDirection="column" width="100%"> | |||
| <MessageContainer> | |||
| <Box> | |||
| <Spacer mt={["75px", 2]} /> | |||
| <Spacer mt={["75px", "75px", 2]} /> | |||
There was a problem hiding this comment.
additional margin top for first message in the conversation
Before:
After:
jpotts244
commented
Jul 21, 2020
| @@ -32,7 +32,7 @@ const Conversations: React.FC<ConversationsProps> = props => { | |||
| .indexOf(selectedConversationID) | |||
|
|
|||
| return ( | |||
| <Container width={["100%", "375px"]}> | |||
| <Container width={["100%", "100%", "375px"]}> | |||
There was a problem hiding this comment.
Adjust container width of conversation list to be 100% for small screens too
Before this change:
After this change:
jpotts244
commented
Jul 21, 2020
| height: calc(100vh - 55px); | ||
| `} | ||
| & > * { | ||
| overflow-y: scroll; | ||
| overflow-x: hidden; | ||
| } | ||
| & > .fresnel-greaterThan-xs { | ||
| > .fresnel-greaterThan-sm { |
There was a problem hiding this comment.
Adjustment needed to align inbox header with inbox col:
Before:
After:
jpotts244
requested review from
jo-rs,
lilyfromseattle,
MounirDhahri,
xtina-starr,
zephraph and
sepans
damassi
reviewed
Jul 21, 2020
| height: calc(100vh - 55px); | ||
| `} | ||
| & > * { | ||
| overflow-y: scroll; | ||
| overflow-x: hidden; | ||
| } | ||
| & > .fresnel-greaterThan-xs { | ||
| > .fresnel-greaterThan-sm { |
There was a problem hiding this comment.
Just as an FYI, there's the ability to use your own container here. Not saying this is a better way but it might be a bit nicer than digging into implementation css.
There was a problem hiding this comment.
Good call out! We'll look at improving this in a separate PR.
jpotts244
force-pushed
the
sizing-updates
branch
from
1aae866
to
47df52d
Compare
jpotts244
commented
Jul 21, 2020
| ${media.xs` | ||
| height: calc(100vh - 55px); | ||
| ${media.md` | ||
| height: calc(100vh - 60px); |
There was a problem hiding this comment.
Adjustment to address super tall section on small screens plus remove single scrollbar
Before:
After:
zephraph
approved these changes
Jul 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust break points for tablet experience
We want tablet to display the same experience as mobile:
