Correct orientation interaction docs and add usage examples to ssr demo #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, in this specific case, but some other interaction rules may not require it, which is why we ended up not adding that negation by default. (It was added by default in earlier versions, but I think it was due to the definition of the hover interactions that I realised we do not always want negation for interaction rules.) |
alloy
approved these changes
Sep 2, 2020
|
Definitely don't need a bump because we're not changing any runpath code here. Thanks for the 🍐! |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small start to help correct some of the documentation we had around orientation interactions. Specifically prepending
not all andis an important addition to ensure the negation of other potential orientation matches.We'll follow up with #153 to improve the docs further.