chore(examples): Does some cleanup and some dep updates #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damassi
force-pushed
the
damassi/chore/example-deps
branch
from
3443cb4
to
768753b
Compare
|
🚀 PR was released in |
| @@ -19,6 +19,7 @@ | |||
| "compile": "babel src --out-dir dist -s --source-maps --extensions '.ts,.tsx' --ignore src/**/__tests__", | |||
| "kitchen-sink": "cd examples/kitchen-sink && yarn start", | |||
| "lint": "tslint -c tslint.json --project tsconfig.json", | |||
| "postinstall": "yarn compile", | |||
There was a problem hiding this comment.
not sure if it is just me but got some error on installing the latest package
[8/14] ⠐ @apollo/rover
warning Error running install script for optional dependency: "/Users/roderickhsiao/git/kindred-landing/node_modules/cpu-features: Command failed.
Exit code: 127
Command: node buildcheck.js > buildcheck.gypi && node-gyp rebuild
Arguments:
[7/14] ⠄ sharp
[11/14] ⠄ cypress
[13/14] ⠄ ssh2
[8/14] ⠄ @apollo/rover
error /Users/roderickhsiao/git/kindred-landing/node_modules/@artsy/fresnel: Command failed.
Exit code: 127
Command: yarn compile
Arguments:
Directory: /Users/roderickhsiao/git/kindred-landing/node_modules/@artsy/fresnel
Output:
yarn run v1.16.0
warning ../../../../package.json: No license field
$ babel src --out-dir dist -s --source-maps --extensions '.ts,.tsx' --ignore src/**/__tests__There was a problem hiding this comment.
Lightening speed thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed we were getting errors outside of Node 16, so upgraded webpack all around. Also pointed example fresnel package ref to internal code.