Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update MP GraphQL to v15 and peer dependencies [DRAFT / IN-PROGRESS] #5455

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

MounirDhahri
Copy link
Member

This PR updates MP GraphQL to v15 and all required dependencies to the first version that supports that.

As I started upgrading packages, I had some troubles with enums and had to reapply patches we made. Eventually, I was happy to see that the graphql-tools v15 does the same as we do in our patch and there was no need for the patch anymore.

How I QA'd my changes:

  • QA changes on Eigen (spent about 15 minutes here)
  • QA changes on Force (spent about 10 minutes here)
  • QA changes on Volt (need support with that)

Further QA
Any volunteers to QA this together if it gets merged to staging

What comes next after this?
graphql 15 and express-graphql both have experimental @defer and stream branches. I am planning on evaluating the effort for such an integration later

@artsy-peril
Copy link
Contributor

artsy-peril bot commented Dec 1, 2023

@ardatan/aggregate-error

Author: Sindre Sorhus

Description: Create an error from multiple errors

Homepage: https://github.com/sindresorhus/aggregate-error#readme

Createdover 3 years ago
Last Updatedover 1 year ago
LicenseMIT
Maintainers1
Releases6
Direct Dependenciestslib
Keywordsaggregate, error, combine, multiple, many, collection, iterable and iterator
README

aggregate-error Build Status

Create an error from multiple errors

Install

$ npm install aggregate-error

Usage

const AggregateError = require('aggregate-error');

const error = new AggregateError([new Error('foo'), 'bar', {message: 'baz'}]);

throw error;
/*
AggregateError:
    Error: foo
        at Object.<anonymous> (/Users/sindresorhus/dev/aggregate-error/example.js:3:33)
    Error: bar
        at Object.<anonymous> (/Users/sindresorhus/dev/aggregate-error/example.js:3:13)
    Error: baz
        at Object.<anonymous> (/Users/sindresorhus/dev/aggregate-error/example.js:3:13)
    at AggregateError (/Users/sindresorhus/dev/aggregate-error/index.js:19:3)
    at Object.<anonymous> (/Users/sindresorhus/dev/aggregate-error/example.js:3:13)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.runMain (module.js:590:10)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
*/

for (const individualError of error) {
	console.log(individualError);
}
//=> [Error: foo]
//=> [Error: bar]
//=> [Error: baz]

API

AggregateError(errors)

Returns an Error that is also an Iterable for the individual errors.

errors

Type: Array<Error|Object|string>

If a string, a new Error is created with the string as the error message.

If a non-Error object, a new Error is created with all properties from the object copied over.

New dependencies added: @ardatan/aggregate-error.

Generated by 🚫 dangerJS against b78dc99

@MounirDhahri MounirDhahri marked this pull request as draft December 1, 2023 14:23
@MounirDhahri
Copy link
Member Author

MounirDhahri commented Dec 1, 2023

I will remove reviewers until I fix the broken tests
I will keep the PR open in order for tests to run

@MounirDhahri MounirDhahri marked this pull request as ready for review December 1, 2023 14:42
@MounirDhahri MounirDhahri changed the title feat: update MP GraphQL to v15 and peer dependencies feat: update MP GraphQL to v15 and peer dependencies [DRAFT / IN-PROGRESS] Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant