Upgrade to relay v7 #3017
Upgrade to relay v7 #3017
Conversation
artsy-peril
bot
added
the
Version: Patch
| export type Accept_order$key = { | ||
| readonly " $data"?: Accept_order$data; | ||
| readonly " $fragmentRefs": FragmentRefs<"Accept_order">; | ||
| }; |
There was a problem hiding this comment.
All of these additions are to support the experimental hooks (which needs react-relay to be installed from 1pm鈥檚 experimental dist-tag).
| @@ -25,17 +25,14 @@ index d0ae8f5..3d47c54 100755 | |||
| sources.push(source.body); | |||
| astDefinitions.push.apply(astDefinitions, (0, _toConsumableArray2["default"])(ast.definitions)); | |||
| }); | |||
| @@ -15352,9 +15352,10 @@ function find(tagFinder, text, absPath) { | |||
| @@ -17478,9 +17478,7 @@ function find(tagFinder, text, absPath) { | |||
There was a problem hiding this comment.
What do these two patches do and why are they needed?
There was a problem hiding this comment.
This relay-compiler patch is to give us 'clickable' file names with correct line:column numbers in error messages.
based on @alloy's PR here: facebook/relay#2752 (which probably won't get merged as-is because it would bust the relay compiler cache of all facebook devs, which apparently is a big deal)
There was a problem hiding this comment.
@ds300 so to confirm, if the two patches in this PR were to suddenly go away it would have no effect on application behavior?
There was a problem hiding this comment.
Although you would have to clear the relay-compiler cache in $TMPDIR
|
That seemed easy! (besides the patch). |
alloy
added
Version: Minor
|
馃殌 PR was released in v22.1.0 馃殌 |
馃搱