Upgrade to Clap 4. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This jumps two major versions. Notably, this switches from the builder pattern to the Derive API. In the past few years, Clap has actively distanced themselves from the Yaml-based approach we were taking advantage of for manpage generation. Thankfully, there's a `clap_mangen` library that generates the manpage from the command object.
arusahni
force-pushed
the
chore/upgrade-clap
branch
from
c92b55e
to
78ebbd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This jumps two major versions. Notably, this switches from the builder pattern to the Derive API. In the past few years, Clap has actively distanced themselves from the Yaml-based approach we were taking advantage of for manpage generation. Thankfully, there's a
clap_mangenlibrary that generates the manpage from the command object.The manpage does advise the user to use
git-reqinstead ofgit req. This is an issue(?) withclap_mangen, which would be fixed by clap-rs/clap#4758.