Skip to content

Commit

Permalink
Update node-7.1.0.sh added additional 'sed'
Browse files Browse the repository at this point in the history
Thanks for your build script. It was one of the few working ones I found. It compiled Node `7.10.1` (using ndk r15 latest) successfully.
It does not compile Node as shared library unfortunately.

One addition to the script that was necessary however, was undefining `HAVE_GETSERVBYPORT_R`

(taken from @gartner build script in nodejs/node#10341 (comment))
  • Loading branch information
aschrijver committed Aug 12, 2017
1 parent c1f3285 commit 0b508d5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions android/build/node-v7.1.0.sh
Expand Up @@ -24,6 +24,9 @@ sed -i "s/uv__getiovmax()/1024/" $MEDIR/../$ME/deps/uv/src/unix/stream.c
sed -i "s/UV__POLLIN/1/g" $MEDIR/../$ME/deps/uv/src/unix/core.c
sed -i "s/UV__POLLOUT/4/g" $MEDIR/../$ME/deps/uv/src/unix/core.c

# see # see https://github.com/nodejs/node/issues/3074
sed -i 's/#define HAVE_GETSERVBYPORT_R 1/#undef HAVE_GETSERVBYPORT_R/' deps/cares/config/android/ares_config.h

export CC="$CC --sysroot=$ANDROID -I$ANDROID/include -L$ANDROID/lib"
export CXX="$CXX --sysroot=$ANDROID -I$ANDROID/include -L$ANDROID/lib"
export CFLAGS="$CFLAGS $CXXCONFIGFLAGS $CXXLIBPLUS $PIEFLAG"
Expand Down

0 comments on commit 0b508d5

Please sign in to comment.