Add inputstream.adaptive as dependency, without videos fail to play.

[mistervee]

Types of changes

• [x ] Bug fix (non-breaking change which fixes an issue)

[mistervee]

Netflix failed to play videos unless inputstream.adaptive was installed.

[jakermx]

Kodi 18 comes with inputstream.adaptive preinstalled as system library, so you dont need to do anything if you are on Kodi 18, but if you are trying to don it on other versions or uf you are compilling it by yourself, you sholud add it before compilling, so thats is why it is named Netflix addon for Kodi 18...

:)

[MilhouseVH]

Kodi 18 comes with inputstream.adaptive preinstalled as system library

I don't think that's the case, actually (some versions of Kodi may bundle inputstream.adaptive but I don't think it's the norm). Adding inputstream.adaptive as a Netflix dependency (and the same for the Amazon and other inputstream.adaptive-based addons) would make sense IMHO.

[titomontes]

I just downloaded a nightly WITHOUT inputstream.adaptive installed, so I had to look for it. Makes sense to include it.

[JinRonin]

We already use inputstream.helper to handle it.
Adding this to dependency will not automatically install/enable it for you.

From the helpers description:
"It is recommended to not add your InputStream add-on as a dependency in addon.xml. It can cause confusion with users not being able to install your add-on because the InputStream add-on is disabled. InputStream Helper addresses issues such as these and helps the user to install/enable required InputStream components."

[MilhouseVH]

@JinRonin inputstream.helper won't install inputstream.adaptive, users are surely in a worse position if you follow that advice as the Netflix add-on will install successfully (along with inputstream.helper) but then the Netflix add-on will fail to play a video (as described in this issue) because inputstream.adaptive isn't installed/enabled. Adding inputstream.adaptive as a dependency would install the inputstream.adaptive add-on automatically, and probably enable it if already installed but disabled. So I don't see the downside, to be honest.

But I'm not an expert on add-ons so will leave it to you - I just wanted to post that Kodi distributions will not normally include inputstream.adaptive (disabled or not), so this is likely to be a bigger issue in future.

[JinRonin]

True, it wont install it, but give a more detailed information that something is missing or will enable it in case its installed and disabled.
Inputstream adaptive is a binary addon that can not be automatically installed when you add it as dependency nor will it enable it.
The user always have to install it manually if its not included.