Skip to content

Commit

Permalink
fix(qwik): don't externalise @unpic/core dep (#254)
Browse files Browse the repository at this point in the history
I'm not sure why, but when installed with pnpm, rollup is unable to resolve the `@unpic/core` transitive dependency. This PR moves the package out of external deps, so that it is compiled into the bundle. Fixes #69
  • Loading branch information
ascorbic committed Jun 19, 2023
1 parent bf3c71b commit 089245b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 10 deletions.
2 changes: 2 additions & 0 deletions examples/qwik/netlify.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[build]
ignore = "false"
4 changes: 1 addition & 3 deletions packages/qwik/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
"@types/node-fetch": "^2.6.2",
"@typescript-eslint/eslint-plugin": "5.59.11",
"@typescript-eslint/parser": "5.59.11",
"@unpic/core": "workspace:^",
"eslint": "8.42.0",
"eslint-plugin-qwik": "^0.103.0",
"node-fetch": "3.3.1",
Expand All @@ -60,8 +61,5 @@
},
"peerDependencies": {
"@builder.io/qwik": "*"
},
"dependencies": {
"@unpic/core": "workspace:^"
}
}
3 changes: 0 additions & 3 deletions packages/qwik/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ export default defineConfig(() => {
formats: ["es", "cjs"],
fileName: (format) => `index.qwik.${format === "es" ? "mjs" : "cjs"}`,
},
rollupOptions: {
external: ["@unpic/core"],
},
},
plugins: [qwikVite()],
};
Expand Down
7 changes: 3 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 089245b

Please sign in to comment.