Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds pipx plugin for asdf #804

Merged
merged 1 commit into from
May 15, 2023
Merged

feat: adds pipx plugin for asdf #804

merged 1 commit into from
May 15, 2023

Conversation

yozachar
Copy link
Contributor

@yozachar yozachar commented Apr 19, 2023 •
edited

Summary

Description:

Checklist

  • Format with scripts/format.bash
  • Test locally with scripts/test_plugin.bash --file plugins/pipx
  • Your plugin CI tests are green
    • Tip: use the plugin_test action from asdf-actions in your plugin CI

@yozachar yozachar requested a review from a team as a code owner April 19, 2023 08:54
jthegedus
jthegedus reviewed Apr 19, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@yozachar yozachar requested a review from jthegedus April 22, 2023 05:44
@yozachar

This comment was marked as outdated.

Sign in to view
@yozachar yozachar marked this pull request as draft May 4, 2023 04:38
@yozachar
Copy link
Contributor Author

yozachar commented May 4, 2023

Ready.

The hiccup was: pypa/pipx#974. Resolved by: pypa/pipx#278 (comment)

@yozachar yozachar marked this pull request as ready for review May 4, 2023 10:05
jthegedus
jthegedus approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@jthegedus jthegedus merged commit a4b5f55 into asdf-vm:master May 15, 2023
4 checks passed
mbutov pushed a commit to mbutov/asdf-plugins that referenced this pull request May 6, 2024
@yozachar
feat: adds pipx plugin (asdf-vm#804)
5d201a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthegedus jthegedus jthegedus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yozachar @jthegedus