platform_types: Convert Windows HANDLE types to isize
#797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
platform-types-windows-handle-isize
branch
from
9b1223a
to
95460d4
Compare
Ralith
approved these changes
Oct 11, 2023
The `windows` crate treats these as `isize` rather than raw void pointers: https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/Foundation/struct.HWND.html And `raw-window-handle 0.6` recently started to do the same: rust-windowing/raw-window-handle#136 However, the win32 documentation still states that these should be `PVOID`: https://learn.microsoft.com/en-us/windows/win32/winprog/windows-data-types
MarijnS95
force-pushed
the
platform-types-windows-handle-isize
branch
from
ce24c51
to
d51682b
Compare
Yup, see also discussion in microsoft/windows-rs#1643. Apologies for not making that change explicitly, I intended to do so but it must have gotten it mixed in with the linked PR. |
|
Thanks @madsmtm, that issue seems rather long and confusing. The TL;DR being that even if a handle may (sometimes?) be a pointer, the user shouldn't be aware of this (and always use appropriate APIs) so an I'll go ahead and merge this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
windowscrate treats these asisizerather than raw void pointers:https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/Foundation/struct.HWND.html
And
raw-window-handle 0.6recently started to do the same:rust-windowing/raw-window-handle#136
However, the win32 documentation still states that these should be
PVOID:https://learn.microsoft.com/en-us/windows/win32/winprog/windows-data-types
Hence I'm not super confident what the right step forward is:
isizeis a breaking change (we'll do a breaking release soon™™™ anyway) but plays more nicely with interop with other crates. @madsmtm was your motivation forraw-window-handlealso the type representation in windows-rs?