Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified code #1

Merged
merged 3 commits into from Nov 19, 2022
Merged

Simplified code #1

merged 3 commits into from Nov 19, 2022

Conversation

radarhere
Copy link

Suggestions for python-pillow#6747

  • I've made a change to WebPImagePlugin, simplifying the code in my opinion.
  • I was wondering why your test didn't fail on CentOS 7, until I realised the fill behaviour only became the default in libwebp 0.5.0. So I've noted that in the test.
  • If you aren't on board with my stylistic changes to your test code, feel free to disagree.
  • I found that our test suite passes if I check if the images are equal, not just similar. Did you find that it didn't pass in some environment, or were you just copying code from another test? I suspect that the lossless argument is what makes this pass.

@ashafaei ashafaei merged commit c01ecac into ashafaei:webp-params Nov 19, 2022
@radarhere radarhere deleted the webp-params branch November 19, 2022 07:32
@ashafaei
Copy link
Owner

@radarhere Thanks for the pull-request on the pull-request. It took me a while to realize what was going on!
I didn't know about the "equal" function. I checked a few test functions to understand how you do it and tried to make it like them. Everything looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants