Make the library accessible now #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added an extra prop to the component so as to make the app more accessible for android and ios both platform like for the current version app is not accessible whenever talkback focus is on the toggle button it does not describe anything but now it will state it as : lets say we have made toggle button for enabling location just, for example, then talk-back would narrate it as 'location, On / Off, toggle button'
|
no need to have new changes now |
|
Hi @asgupta9, can you explain what your code does and provide some references regarding the same? |
|
Hi @ashishpandey001 |
|
Yes, I understood that from your PR / commit description. I will review it this weekend and probably then merge it to the master. Thank you. |
|
Have You checked in my PR |
|
Yes, I did check it but I couldn't find any relevant documentation explaining how it works. Could you guide me to some relevant docs? |
|
Yaah sure,
Here is the link of the official facebook react native guidance -
https://reactnative.dev/docs/accessibility
Thanks,
Akash Gupta
…On Wed, 29 Apr, 2020, 21:29 Ashish Pandey, ***@***.***> wrote:
Yes, I did check it but I couldn't find any relevant documentation
explaining how it works. Could you guide me to some relevant docs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFM2LEKPUIVDHIVQZESF23DRPBFE7ANCNFSM4JZ4OEQA>
.
|
|
Let me know if you have any concern :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add my new commits to your library so as to make your library accessible