Skip to content

Commit

Permalink
Fix resource leak with proxy
Browse files Browse the repository at this point in the history
The external resources proxy uses the http-proxy-middleware library to
mange the proxing of requests. That in turn uses the node-http-proxy
library which unfortunately has not been updated in a while and has
a bug which results in sockets not being closed properly. This commit
fixes that by swapping that library out with a patched version found
here http-party/node-http-proxy#1559
  • Loading branch information
callumgare committed May 15, 2023
1 parent cd568f0 commit 8103641
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
3 changes: 3 additions & 0 deletions package.json
Expand Up @@ -160,5 +160,8 @@
"@storybook/builder-webpack5": "^6.4.22",
"@storybook/manager-webpack5": "^6.4.22",
"webpack": "^5.72.1"
},
"resolutions": {
"http-proxy-middleware/http-proxy": "github:Jimbly/node-http-proxy"
}
}
5 changes: 2 additions & 3 deletions yarn.lock
Expand Up @@ -8718,10 +8718,9 @@ http-proxy-middleware@^2.0.6:
is-plain-obj "^3.0.0"
micromatch "^4.0.2"

http-proxy@^1.18.1:
http-proxy@^1.18.1, "http-proxy@github:Jimbly/node-http-proxy":
version "1.18.1"
resolved "https://registry.yarnpkg.com/http-proxy/-/http-proxy-1.18.1.tgz#401541f0534884bbf95260334e72f88ee3976549"
integrity sha512-7mz/721AbnJwIVbnaSv1Cz3Am0ZLT/UBwkC92VlxhXv/k/BBQfM2fXElQNC27BVGr0uwUpplYPQM9LnaBMR5NQ==
resolved "https://codeload.github.com/Jimbly/node-http-proxy/tar.gz/ba0c414cd03799e357c5d867c11dea06a9c34ec8"
dependencies:
eventemitter3 "^4.0.0"
follow-redirects "^1.0.0"
Expand Down

0 comments on commit 8103641

Please sign in to comment.