Merge pull request #891 from piazzesiNiccolo/unit_test_deprecated_ali…

…ases_bug fix bug when rewriting deprecated unittest functions
asottile · Sep 21, 2023 · 443797a · 443797a
2 parents b499613 + c98e8ed
commit 443797a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/pyupgrade/_plugins/unittest_aliases.py b/pyupgrade/_plugins/unittest_aliases.py
@@ -7,6 +7,7 @@
 from tokenize_rt import Offset
 
 from pyupgrade._ast_helpers import ast_to_offset
+from pyupgrade._ast_helpers import has_starargs
 from pyupgrade._data import register
 from pyupgrade._data import State
 from pyupgrade._data import TokenFunc
@@ -59,7 +60,10 @@ def visit_Call(
             isinstance(node.func, ast.Attribute) and
             isinstance(node.func.value, ast.Name) and
             node.func.value.id == 'unittest' and
-            node.func.attr in FUNCTION_MAPPING
+            node.func.attr in FUNCTION_MAPPING and
+            not has_starargs(node) and
+            not node.keywords and
+            len(node.args) == 1
     ):
         func = functools.partial(
             replace_name,

diff --git a/tests/features/unittest_aliases_test.py b/tests/features/unittest_aliases_test.py
@@ -7,14 +7,16 @@
 
 
 @pytest.mark.parametrize(
-    ('s',),
+    's',
     (
         pytest.param(
             'class ExampleTests:\n'
             '    def test_something(self):\n'
             '        self.assertEqual(1, 1)\n',
             id='not a deprecated alias',
         ),
+        'unittest.makeSuite(Tests, "arg")',
+        'unittest.makeSuite(Tests, prefix="arg")',
     ),
 )
 def test_fix_unittest_aliases_noop(s):