remove object class from base classes in type calls #731
Conversation
as this tests a noop, the result should be equal to src
…ins/type_bases_object as it is not shared
… calls, adding arguments to support the difference between the two cases
|
@asottile what should be done for |
|
so the weird thing is >>> x = type('a', (), {})
>>> x.__bases__
(<type 'object'>,)I would probably remove it anyway 🤷 |
…hrough all tokens
…ed with empty bases)
# Conflicts: # pyupgrade/_plugins/type_bases_object.py
…and type calls, adding arguments to support the difference between the two cases" This reverts commit f1afe8e
| type_start = find_open_paren(tokens, 0) | ||
| bases_start = find_open_paren(tokens, type_start + 1) | ||
| bases, end = parse_call_args(tokens, bases_start) | ||
| for base_start, base_end in bases: # pragma: no cover |
There was a problem hiding this comment.
can't ship with this -- means you haven't tested everything
this function is way too complicated -- I don't think it's correct either. you should also be able to use the original object base index without needing to re-find it here and utilize the argument removal functions
|
|
||
| def remove_base_class_from_type_call(i: int, tokens: list[Token]) -> None: | ||
| type_start = find_open_paren(tokens, 0) | ||
| bases_start = find_open_paren(tokens, type_start + 1) |
There was a problem hiding this comment.
this isn't necessarily correct -- type(class_name(), (...))
| del tokens[base_start:base_end] | ||
| # (foo, bar, ..., object[,]) -> (foo, bar, ...[,]) | ||
| else: | ||
| if tokens[base_end - 1].name == UNIMPORTANT_WS and \ |
|
I won't have much time to work on this anymore :/ -- closing the PR so others might take a stab at this p.s. thank you for being patient with me through this (my first contribution), this was an educating experience :) |
This solves #532