Add --check-only and --diff options #840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usefull to only report what file would be changed by appyling pyupgrade. Signed-off-by: Thomas Faivre <thomas.faivre@6wind.com>
In conjunction with --check-only, useful to see what would be changed by applying pyupgrade. Signed-off-by: Thomas Faivre <thomas.faivre@6wind.com>
|
Hello, Can I have more information on the reason for this PR being closed? Thanks for the help! |
|
general open source advice: (1) search the issue tracker for duplicates |
Repository owner
locked as resolved and limited conversation to collaborators
Jun 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I would like to be able to visualize what modifications would be applied by pyupgrade without modifying files on disk.
These are options that are available in other linting tools like black, isort, autoflake, and others.
What do you think?
I am hesitating between --check and --check-only because we see both in other tools.
I would also like to see some colors on the diff (I like colors! :D), but that would require either some external library (which can be annoying) or handling terminal color codes in pyupgrade directly (which can be annoying aswell). I can be a separate PR though!
Last thing, would it be possible to have a version 3.3.3 with these patches so that it can be available for Python 3.7? I don't have much ground to stand on for this as it is the version for Debian 10 which is oldoldstable since Saturday ^^
Your call!
Thanks!