Defaultdict lambdas #901
Merged
Defaultdict lambdas #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnknownPlatypus
commented
Oct 2, 2023
UnknownPlatypus
commented
Oct 2, 2023
UnknownPlatypus
commented
Oct 2, 2023
asottile
reviewed
Oct 3, 2023
UnknownPlatypus
force-pushed
the
defaultdict-lambdas
branch
from
6c24f27
to
bbf23c8
Compare
asottile
reviewed
Oct 5, 2023
asottile
reviewed
Oct 7, 2023
README.md
Outdated
Comment on lines
84
to
85
| -defaultdict(lambda: None) | ||
| +defaultdict() |
There was a problem hiding this comment.
this one actually isn't equivalent
Comment on lines
24
to
25
| else: | ||
| return 'float' |
There was a problem hiding this comment.
there's also 0j which is complex
asottile
force-pushed
the
defaultdict-lambdas
branch
from
ba9dcc4
to
f001635
Compare
|
Nice feature, it just fixed seven cases on a client code base. Thanks both! |
|
Thanks Adam and thanks Anthony for the thorough review and tweaks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #899
I left a few comments with some questions.