Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add write_aspect_bazelrc_presets macro #370

Merged
merged 1 commit into from Feb 17, 2023
Merged

feat: add write_aspect_bazelrc_presets macro #370

merged 1 commit into from Feb 17, 2023

Conversation

gregmagolan
Copy link
Member

No description provided.

@gregmagolan gregmagolan force-pushed the bazelrc_readme_update branch 5 times, most recently from 2cd06c4 to 4948275 Compare February 17, 2023 06:02
@alexeagle
Copy link
Member

Will this show properly on the docsite?

@alexeagle
Copy link
Member

Maybe we want to use the term "preset" for these

Maybe update Aspect init too

@gregmagolan
Copy link
Member Author

gregmagolan commented Feb 17, 2023 •
edited

I like "preset". Lines up better with existing patterns. I'll update.

@gregmagolan
Copy link
Member Author

Will this show properly on the docsite?

Good point. I could make this README the SoT for the docsite itself.

@gregmagolan gregmagolan force-pushed the bazelrc_readme_update branch 2 times, most recently from 49c2e46 to 52e0926 Compare February 17, 2023 20:31
@gregmagolan gregmagolan force-pushed the bazelrc_readme_update branch 5 times, most recently from 6c40d01 to 52dbc6b Compare February 17, 2023 22:10
@gregmagolan gregmagolan changed the title chore: updated .aspect/bazelrc/README.md feat: add write_aspect_bazelrc_presets macro Feb 17, 2023
@gregmagolan gregmagolan force-pushed the bazelrc_readme_update branch 5 times, most recently from 82bd5b2 to b299605 Compare February 17, 2023 22:24
@gregmagolan gregmagolan merged commit 569fa37 into main Feb 17, 2023
@gregmagolan gregmagolan deleted the bazelrc_readme_update branch February 17, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gregmagolan @alexeagle