Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update YQ #405

Merged
merged 4 commits into from May 2, 2023
Merged

Chore: update YQ #405

merged 4 commits into from May 2, 2023

Conversation

henkerik
Copy link
Contributor

@henkerik henkerik commented Apr 12, 2023

Updated the list of available YQ versions. We would like to use a feature in a newer version. This may be a breaking change since the value of DEFAULT_YQ_VERSION is also updated in this PR.

Type of change

  • Chore (any other change that doesn't affect source or test files)

For changes visible to end-users

  • Breaking change (this change will force users to change their own code or config)
  • Suggested release notes are provided below:

Default YQ version change from 4.25.2 to 4.33.3.

Test plan

  • Covered by existing test cases

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 🙏

@gregmagolan
Copy link
Member

@henkerik Are there breaking API changes in YQ between 4.25.2 to 4.33.3? Some of the existing test cases are failing with the change.

@gregmagolan gregmagolan self-requested a review April 16, 2023 15:49
@henkerik
Copy link
Contributor Author

@gregmagolan I made some minor changes to the testcases. You can review them here:

b040e55

@jbedard
Copy link
Member

jbedard commented Apr 19, 2023

@henkerik are there release notes describing the breaking changes?

@gregmagolan
Copy link
Member

Thanks for updating the test cases. Looks like you just have to run bazel run //docs:update to green up the docs

@gregmagolan
Copy link
Member

@henkerik I rebased, updated docs one more time and force pushed. Will land and cut a minor release next.

Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@gregmagolan gregmagolan merged commit 39d556a into aspect-build:main May 2, 2023
16 checks passed
@alexeagle
Copy link
Member

may be a breaking change since the value of DEFAULT_YQ_VERSION is also updated

It sure was! bazel-contrib/rules_oci#212 tripped on this, so any users of rules_oci who have a newer bazel-lib get an error from yq.

I'm not sure what to do about this yet. I'm tempted to revert the DEFAULT_YQ_VERSION and cut another bazel-lib, and/or yank this release from BCR.

alexeagle added a commit that referenced this pull request May 5, 2023
The new version of yq is quite breaking, as it requires '-oj -r' for continued operation in rules_oci.
We can do a default version flip later when more downstream projects are compatible.
alexeagle added a commit that referenced this pull request May 5, 2023
The new version of yq is quite breaking, as it requires '-oj -r' for continued operation in rules_oci.
We can do a default version flip later when more downstream projects are compatible.
alexeagle added a commit that referenced this pull request May 5, 2023
The new version of yq is quite breaking, as it requires '-oj -r' for continued operation in rules_oci.
We can do a default version flip later when more downstream projects are compatible.
alexeagle added a commit that referenced this pull request May 5, 2023
The new version of yq is quite breaking, as it requires '-oj -r' for continued operation in rules_oci.
We can do a default version flip later when more downstream projects are compatible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants