refactor: cleanup glob implementation, add tests #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
commented
May 5, 2023
jbedard
force-pushed
the
419-prefactor
branch
2 times, most recently
from
ac40d71
to
ef8a388
Compare
gregmagolan
reviewed
May 5, 2023
| return _glob_match_test( | ||
| ctx, | ||
| "**/*.tf", | ||
| matches = ["a/b.tf", "ab/cd/e.tf"], |
There was a problem hiding this comment.
This was the one that broke the release right? It should also match a .tf file at the root: "c.tf"
There was a problem hiding this comment.
Yeah, and this PR doesn't fix it. This just does some prefactors before the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefactor to #419
To add more test coverage and cleanup to keep the actual fix minimal.
Type of change
Test plan