Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement chr, ord, and hex #425

Merged
merged 3 commits into from May 15, 2023
Merged

feat: implement chr, ord, and hex #425

merged 3 commits into from May 15, 2023

Conversation

thesayyn
Copy link
Member

@thesayyn thesayyn commented May 8, 2023 •
edited

Type of change

  • New feature or functionality (change which adds functionality) [FR]: ord, chr, hex #418

  • Relevant documentation has been updated

Test plan

  • New test cases added

gregmagolan
gregmagolan reviewed May 9, 2023
View reviewed changes
lib/string.bzl Outdated Show resolved Hide resolved
gregmagolan
gregmagolan approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@alexeagle
Copy link
Member

Another nit: how did we decide on string.bzl as the public API rather than strings.bzl ?

@thesayyn
Copy link
Member Author

thesayyn commented May 9, 2023

Another nit: how did we decide on string.bzl as the public API rather than strings.bzl ?

we haven't actually. open to suggestions. strings.bzl sounds more appropriate to me.

@thesayyn
Copy link
Member Author

to get this going; assuming Alex and I agree on strings.bzl, should I rename this to strings.bzl?

@alexeagle
Copy link
Member

yes please, let's go with that. Unless you can find some other starlark implementation that already has a name for a module that provides these (but I expect there isn't since they're proposed as builtin keywords)

@thesayyn
Copy link
Member Author

but I expect there isn't since they're proposed as builtin keywords

true. renamed to strings

@thesayyn thesayyn merged commit 781d1cb into main May 15, 2023
28 of 29 checks passed
@thesayyn thesayyn deleted the feat_chr_ord_hex branch May 15, 2023 19:15
@thesayyn thesayyn mentioned this pull request May 15, 2023
Closed
f0rmiga pushed a commit to aspect-build/talkie that referenced this pull request Aug 11, 2023
@renovate
chore(deps): update dependency aspect_bazel_lib to v1.32.1 (#2344)
028b215 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [aspect_bazel_lib](https://togithub.com/aspect-build/bazel-lib) |
http_archive | minor | `v1.31.2` -> `v1.32.1` |
| [aspect_bazel_lib](https://togithub.com/aspect-build/bazel-lib) |
http_archive | patch | `v1.32.0` -> `v1.32.1` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>aspect-build/bazel-lib</summary>

###
[`v1.32.1`](https://togithub.com/aspect-build/bazel-lib/releases/tag/v1.32.1)

[Compare
Source](https://togithub.com/aspect-build/bazel-lib/compare/v1.32.0...v1.32.1)

#### Using Bzlmod with Bazel 6:

1.  Enable with `common --enable_bzlmod` in `.bazelrc`.
2.  Add to your `MODULE.bazel` file:

```starlark
bazel_dep(name = "aspect_bazel_lib", version = "1.32.1")
```

> Read more about bzlmod: <https://blog.aspect.dev/bzlmod>

#### Using WORKSPACE

Paste this snippet into your  file:

```starlark
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "aspect_bazel_lib",
    sha256 = "e3151d87910f69cf1fc88755392d7c878034a69d6499b287bcfc00b1cf9bb415",
    strip_prefix = "bazel-lib-1.32.1",
    url = "https://github.com/aspect-build/bazel-lib/releases/download/v1.32.1/bazel-lib-v1.32.1.tar.gz",
)

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "aspect_bazel_lib_dependencies")

aspect_bazel_lib_dependencies()

```

Optional toolchains:

```starlark

### Register the following toolchain to use jq

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "register_jq_toolchains")

register_jq_toolchains()

### Register the following toolchain to use yq

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "register_yq_toolchains")

register_yq_toolchains()
```

#### What's Changed

- chore(deps): update dependency bazel to v6.2.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[aspect-build/bazel-lib#433
- fix(stardoc): stop skipping stardoc w bzlmod by
[@&#8203;alexeagle](https://togithub.com/alexeagle) in
[aspect-build/bazel-lib#440

**Full Changelog**:
aspect-build/bazel-lib@v1.32.0...v1.32.1

###
[`v1.32.0`](https://togithub.com/aspect-build/bazel-lib/releases/tag/v1.32.0)

[Compare
Source](https://togithub.com/aspect-build/bazel-lib/compare/v1.31.3...v1.32.0)

#### Using Bzlmod with Bazel 6:

1.  Enable with `common --enable_bzlmod` in `.bazelrc`.
2.  Add to your `MODULE.bazel` file:

```starlark
bazel_dep(name = "aspect_bazel_lib", version = "1.32.0")
```

> Read more about bzlmod: <https://blog.aspect.dev/bzlmod>

#### Using WORKSPACE

Paste this snippet into your  file:

```starlark
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "aspect_bazel_lib",
    sha256 = "f1c181b910f821072f38ee45bb87db6b56275458c7f832c54c54ba6334119eca",
    strip_prefix = "bazel-lib-1.32.0",
    url = "https://github.com/aspect-build/bazel-lib/releases/download/v1.32.0/bazel-lib-v1.32.0.tar.gz",
)

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "aspect_bazel_lib_dependencies")

aspect_bazel_lib_dependencies()

```

Optional toolchains:

```starlark

### Register the following toolchain to use jq

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "register_jq_toolchains")

register_jq_toolchains()

### Register the following toolchain to use yq

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "register_yq_toolchains")

register_yq_toolchains()
```

#### What's Changed

- chore: add trailing newline by
[@&#8203;thesayyn](https://togithub.com/thesayyn) in
[aspect-build/bazel-lib#439

**Full Changelog**:
aspect-build/bazel-lib@v1.31.4...v1.32.0

###
[`v1.31.3`](https://togithub.com/aspect-build/bazel-lib/releases/tag/v1.31.3)

[Compare
Source](https://togithub.com/aspect-build/bazel-lib/compare/v1.31.2...v1.31.3)

#### Using Bzlmod with Bazel 6:

1.  Enable with `common --enable_bzlmod` in `.bazelrc`.
2.  Add to your `MODULE.bazel` file:

```starlark
bazel_dep(name = "aspect_bazel_lib", version = "1.31.3")
```

> Read more about bzlmod: <https://blog.aspect.dev/bzlmod>

#### Using WORKSPACE

Paste this snippet into your  file:

```starlark
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "aspect_bazel_lib",
    sha256 = "25d607705a79ae9e8c4be8c770604646799c3e37df047be75a6f2f284d44716d",
    strip_prefix = "bazel-lib-1.31.3",
    url = "https://github.com/aspect-build/bazel-lib/releases/download/v1.31.3/bazel-lib-v1.31.3.tar.gz",
)

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "aspect_bazel_lib_dependencies")

aspect_bazel_lib_dependencies()

```

Optional toolchains:

```starlark

### Register the following toolchain to use jq

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "register_jq_toolchains")

register_jq_toolchains()

### Register the following toolchain to use yq

load("@&#8203;aspect_bazel_lib//lib:repositories.bzl", "register_yq_toolchains")

register_yq_toolchains()
```

#### What's Changed

- chore: update workflows config by
[@&#8203;kormide](https://togithub.com/kormide) in
[aspect-build/bazel-lib#429
- feat: implement chr, ord, and hex by
[@&#8203;thesayyn](https://togithub.com/thesayyn) in
[aspect-build/bazel-lib#425
- feat: introduce expand_template tool by
[@&#8203;thesayyn](https://togithub.com/thesayyn) in
[aspect-build/bazel-lib#436
- fix: remove missing toolchain load by
[@&#8203;thesayyn](https://togithub.com/thesayyn) in
[aspect-build/bazel-lib#437

**Full Changelog**:
aspect-build/bazel-lib@v1.31.2...v1.31.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/aspect-build/silo).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMDUuMiIsInVwZGF0ZWRJblZlciI6IjM1LjEwNS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thesayyn @alexeagle @gregmagolan