Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support special chars in assert_contains expected expression #426

Merged
merged 1 commit into from May 10, 2023
Merged

fix: support special chars in assert_contains expected expression #426

merged 1 commit into from May 10, 2023

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented May 9, 2023

See aspect-build/rules_js#1045

Type of change

  • Bug fix (change which fixes an issue)

Test plan

  • New test cases added

@jbedard jbedard requested a review from alexeagle May 9, 2023 23:59
jbedard
jbedard commented May 10, 2023
View reviewed changes
lib/testing.bzl Outdated Show resolved Hide resolved
@jbedard jbedard mentioned this pull request May 10, 2023
Merged
@jbedard jbedard requested a review from kormide May 10, 2023 22:40
@jbedard jbedard merged commit b5e9238 into aspect-build:main May 10, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

@kormide kormide kormide approved these changes

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbedard @gregmagolan @kormide