fix(stardoc): stop skipping stardoc w bzlmod #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
commented
May 17, 2023
Newest stardoc has fixed it, and since bzlmod will select the lowest version in the dependencies, our bump here will take effect for users as well.
alexeagle
changed the title
kormide
approved these changes
May 17, 2023
f0rmiga
pushed a commit
to aspect-build/talkie
that referenced
this pull request
Aug 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [aspect_bazel_lib](https://togithub.com/aspect-build/bazel-lib) | http_archive | minor | `v1.31.2` -> `v1.32.1` | | [aspect_bazel_lib](https://togithub.com/aspect-build/bazel-lib) | http_archive | patch | `v1.32.0` -> `v1.32.1` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>aspect-build/bazel-lib</summary> ### [`v1.32.1`](https://togithub.com/aspect-build/bazel-lib/releases/tag/v1.32.1) [Compare Source](https://togithub.com/aspect-build/bazel-lib/compare/v1.32.0...v1.32.1) #### Using Bzlmod with Bazel 6: 1. Enable with `common --enable_bzlmod` in `.bazelrc`. 2. Add to your `MODULE.bazel` file: ```starlark bazel_dep(name = "aspect_bazel_lib", version = "1.32.1") ``` > Read more about bzlmod: <https://blog.aspect.dev/bzlmod> #### Using WORKSPACE Paste this snippet into your file: ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "aspect_bazel_lib", sha256 = "e3151d87910f69cf1fc88755392d7c878034a69d6499b287bcfc00b1cf9bb415", strip_prefix = "bazel-lib-1.32.1", url = "https://github.com/aspect-build/bazel-lib/releases/download/v1.32.1/bazel-lib-v1.32.1.tar.gz", ) load("@​aspect_bazel_lib//lib:repositories.bzl", "aspect_bazel_lib_dependencies") aspect_bazel_lib_dependencies() ``` Optional toolchains: ```starlark ### Register the following toolchain to use jq load("@​aspect_bazel_lib//lib:repositories.bzl", "register_jq_toolchains") register_jq_toolchains() ### Register the following toolchain to use yq load("@​aspect_bazel_lib//lib:repositories.bzl", "register_yq_toolchains") register_yq_toolchains() ``` #### What's Changed - chore(deps): update dependency bazel to v6.2.0 by [@​renovate](https://togithub.com/renovate) in [aspect-build/bazel-lib#433 - fix(stardoc): stop skipping stardoc w bzlmod by [@​alexeagle](https://togithub.com/alexeagle) in [aspect-build/bazel-lib#440 **Full Changelog**: aspect-build/bazel-lib@v1.32.0...v1.32.1 ### [`v1.32.0`](https://togithub.com/aspect-build/bazel-lib/releases/tag/v1.32.0) [Compare Source](https://togithub.com/aspect-build/bazel-lib/compare/v1.31.3...v1.32.0) #### Using Bzlmod with Bazel 6: 1. Enable with `common --enable_bzlmod` in `.bazelrc`. 2. Add to your `MODULE.bazel` file: ```starlark bazel_dep(name = "aspect_bazel_lib", version = "1.32.0") ``` > Read more about bzlmod: <https://blog.aspect.dev/bzlmod> #### Using WORKSPACE Paste this snippet into your file: ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "aspect_bazel_lib", sha256 = "f1c181b910f821072f38ee45bb87db6b56275458c7f832c54c54ba6334119eca", strip_prefix = "bazel-lib-1.32.0", url = "https://github.com/aspect-build/bazel-lib/releases/download/v1.32.0/bazel-lib-v1.32.0.tar.gz", ) load("@​aspect_bazel_lib//lib:repositories.bzl", "aspect_bazel_lib_dependencies") aspect_bazel_lib_dependencies() ``` Optional toolchains: ```starlark ### Register the following toolchain to use jq load("@​aspect_bazel_lib//lib:repositories.bzl", "register_jq_toolchains") register_jq_toolchains() ### Register the following toolchain to use yq load("@​aspect_bazel_lib//lib:repositories.bzl", "register_yq_toolchains") register_yq_toolchains() ``` #### What's Changed - chore: add trailing newline by [@​thesayyn](https://togithub.com/thesayyn) in [aspect-build/bazel-lib#439 **Full Changelog**: aspect-build/bazel-lib@v1.31.4...v1.32.0 ### [`v1.31.3`](https://togithub.com/aspect-build/bazel-lib/releases/tag/v1.31.3) [Compare Source](https://togithub.com/aspect-build/bazel-lib/compare/v1.31.2...v1.31.3) #### Using Bzlmod with Bazel 6: 1. Enable with `common --enable_bzlmod` in `.bazelrc`. 2. Add to your `MODULE.bazel` file: ```starlark bazel_dep(name = "aspect_bazel_lib", version = "1.31.3") ``` > Read more about bzlmod: <https://blog.aspect.dev/bzlmod> #### Using WORKSPACE Paste this snippet into your file: ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "aspect_bazel_lib", sha256 = "25d607705a79ae9e8c4be8c770604646799c3e37df047be75a6f2f284d44716d", strip_prefix = "bazel-lib-1.31.3", url = "https://github.com/aspect-build/bazel-lib/releases/download/v1.31.3/bazel-lib-v1.31.3.tar.gz", ) load("@​aspect_bazel_lib//lib:repositories.bzl", "aspect_bazel_lib_dependencies") aspect_bazel_lib_dependencies() ``` Optional toolchains: ```starlark ### Register the following toolchain to use jq load("@​aspect_bazel_lib//lib:repositories.bzl", "register_jq_toolchains") register_jq_toolchains() ### Register the following toolchain to use yq load("@​aspect_bazel_lib//lib:repositories.bzl", "register_yq_toolchains") register_yq_toolchains() ``` #### What's Changed - chore: update workflows config by [@​kormide](https://togithub.com/kormide) in [aspect-build/bazel-lib#429 - feat: implement chr, ord, and hex by [@​thesayyn](https://togithub.com/thesayyn) in [aspect-build/bazel-lib#425 - feat: introduce expand_template tool by [@​thesayyn](https://togithub.com/thesayyn) in [aspect-build/bazel-lib#436 - fix: remove missing toolchain load by [@​thesayyn](https://togithub.com/thesayyn) in [aspect-build/bazel-lib#437 **Full Changelog**: aspect-build/bazel-lib@v1.31.2...v1.31.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/aspect-build/silo). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMDUuMiIsInVwZGF0ZWRJblZlciI6IjM1LjEwNS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newest stardoc has fixed it, so we want to be able to opt-in.
It would be nice to detect this automatically but I don't have a clever idea how to do that.
cc @fmeum
Type of change
Test plan