Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: yq supports stamping #456

Merged
merged 1 commit into from
Jun 15, 2023
Merged

feat: yq supports stamping #456

merged 1 commit into from
Jun 15, 2023

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Jun 14, 2023

Fixes #223


Type of change

  • New feature or functionality (change which adds functionality)

For changes visible to end-users

  • Relevant documentation has been updated
  • Suggested release notes are provided below:
    Support stamping in yq rules
    

Test plan

  • New test cases added

@CLAassistant
Copy link

CLAassistant commented Jun 14, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!!

@alexeagle
Copy link
Member

Test failure indicates a missing dep in a bzl_library rule - you can likely just bazel run //:gazelle to fix it.

@malt3
Copy link
Contributor Author

malt3 commented Jun 15, 2023

you can likely just bazel run //:gazelle to fix it.

Running gazelle yields a large number of changes that all seem to be unrelated to my PR.

I'm trying to understand what this means (related to stardoc):

File lib/paths.bzl imported '//lib/private:paths.bzl', yet lib/private/paths.bzl was not found, even at roots

EDIT: I understand now what I need to do to get the docs working. There still seems to be a diff when running gazelle though.

@alexeagle
Copy link
Member

Thanks, we just don't have a "gazelle up-to-date" CI check on this repo yet, so HEAD is out-of-date, sorry you tripped on that.

@alexeagle alexeagle merged commit d79f4d4 into aspect-build:main Jun 15, 2023
25 checks passed
@malt3 malt3 deleted the feat/yq-stamping branch June 16, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support stamping on yq rule
3 participants