feat: update copy_to_directory tool to accept the name of its workspace and automatically include files from it
#488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pace and automatically include files from it Refs aspect-build#359. This allows `copy_to_directory` to be run in an external workspace and include files from that workspace automatically once the `copy_to_directory` rule is updated. The rule update needs to be separated from the tool update because the tool is pre-built and vendored rather than built at HEAD.
|
Thanks! @gregmagolan is the author here so I'd like an 👁️ from him |
|
ah, after #532 lands we won't have to do this "release in two halves" dance anymore, so your original PR could land as-is without splitting. |
|
Since this got merged, don't we still need to merge #360 as well? Otherwise the workspace name is never passed into the tool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #359.
This allows
copy_to_directoryto be run in an external workspace and include files from that workspace automatically once thecopy_to_directoryrule is updated. The rule update needs to be separated from the tool update because the tool is pre-built and vendored rather than built at HEAD.This was split off from #360 in order to land the Go changes first and release a new version of the tool.
The new workspace name argument needs to be optional to avoid breaking the
copy_to_directoryrule. Once the rule is updated and released, we should consider making this argument required if the tool is not used elsewhere.I didn't see any direct tests or documentation of the tool itself, so I left those for #360 which will test/document the
copy_to_directoryrule itself. Please let me know if I missed something.I'm also not totally sure if this should be classified as a user-visible
featcommit or a simplerefactor. Probably depends on whether the tool itself is considered public API independent of thecopy_to_Directoryrule?Type of change