Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update_docs with stardoc 0.6.0 and Bazel 7 #494

Merged
merged 1 commit into from Aug 14, 2023

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Aug 9, 2023

Fixes update_docs existing_rules logic with stardoc 0.6.0 and Bazel 7 by making it independent of the name of the internal rules instantiated by the stardoc macro.

Type of change

Bug fix

Test plan

  • Covered by existing test cases
  • Manual testing; please provide instructions so we can reproduce:
    Update stardoc to 0.6.0 and run with USE_BAZEL_VERSION=last_green

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2023

CLA assistant check
All committers have signed the CLA.

@fmeum
Copy link
Contributor Author

fmeum commented Aug 14, 2023

@kormide Could you merge and if possible release?

@kormide kormide merged commit 682d6f2 into aspect-build:main Aug 14, 2023
25 checks passed
@kormide
Copy link
Member

kormide commented Aug 14, 2023

@kormide Could you merge and if possible release?

@fmeum Done. Just need approval for the BCR entry: bazelbuild/bazel-central-registry#839

@fmeum fmeum deleted the fix-stardoc branch August 17, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants