fix(expand_template): correct output permissions #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used hexadecimal where we meant to use octal. 0x666 in binary is 11001100110 but 0666 is 110110110 (9 digits as expected) so this was producing an output like ---xr--r-- 1 108 114 206 Sep 6 20:55 bazel-out/k8-opt/bin/stamped_labels.txt
gregmagolan
approved these changes
Sep 6, 2023
AustinSchuhBRT
approved these changes
Sep 6, 2023
kormide
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used hexadecimal where we meant to use octal.
0x666 in binary is 11001100110 but 0666 is 110110110 (9 digits as expected)
so this was producing an output like
---xr--r-- 1 108 114 206 Sep 6 20:55 bazel-out/k8-opt/bin/stamped_labels.txt
we could fix both to explicit octal notation
0o666and0o777but that's not what any of the "How to set permissions in Go" examples do.Type of change
Test plan
None, just visual inspection and reasoning