Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add --incompatible_disallow_empty_glob to correctness.bazelrc #524

Merged
merged 6 commits into from Sep 19, 2023

Conversation

thirtyseven
Copy link
Contributor

This is a good flag to enable by default because it prevents a common mistake and usually is what users expect.


Type of change

  • Documentation (updates to documentation or READMEs)

For changes visible to end-users

  • Breaking change (this change will force users to change their own code or config)
    • When updating their bazelrc to include this, some users may need to fix broken BUILD files or specify allow_empty=True when they were intentionally relying on the previous behavior.

Test plan

Not sure this applies here.

This is a good flag to enable by default because it prevents a common mistake and usually is what users expect.
@CLAassistant
Copy link

CLAassistant commented Sep 12, 2023

CLA assistant check
All committers have signed the CLA.

@thirtyseven thirtyseven changed the title Add --incompatible_disallow_empty_glob to correctness.bazelrc docs: Add --incompatible_disallow_empty_glob to correctness.bazelrc Sep 12, 2023
@gregmagolan
Copy link
Member

Thanks for the suggestion @thirtyseven. I think this is a good one to add. @alexeagle wdyt?

@alexeagle alexeagle merged commit fc3c318 into aspect-build:main Sep 19, 2023
15 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants