Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow for BUILD files in outputs of write_source_file #540

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: allow for BUILD files in outputs of write_source_file #540

merged 1 commit into from
Sep 21, 2023

Conversation

mattem
Copy link
Member

@mattem mattem commented Sep 21, 2023

Handles the case in write_source_file where the generated output directory contains BUILD files, which can not be globbed through, resulting in incorrect failure states for missing output files.

Closes #536

Type of change

  • Bug fix (change which fixes an issue)

For changes visible to end-users

  • Suggested release notes are provided below:

Handle BUILD files in the output of write_source_file

Test plan

  • New test cases added

kormide
kormide approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@kormide kormide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 . I didn't think to use subpackages.

@mattem mattem merged commit 8fa2127 into main Sep 21, 2023
49 of 50 checks passed
@mattem mattem deleted the build_files_in_out branch September 21, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kormide kormide kormide approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

write_source_file can fail if the output_dir contains a BUILD file
2 participants
@mattem @kormide