Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add propagate_common_{,test_,binary_}rule_attributes to lib/utils. #553

Merged
merged 4 commits into from Sep 26, 2023

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Sep 26, 2023

Type of change

  • New feature or functionality (change which adds functionality)

For changes visible to end-users

  • ✅ Relevant documentation has been updated
  • Suggested release notes are provided below:

Added helper functions propagate_common_rule_attributes, propagate_common_test_rule_attributes and propagate_common_binary_rule_attributes which can be used to forward common attributes to rule invocations when writing macros.

Test plan

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2023

CLA assistant check
All committers have signed the CLA.

lib/private/utils.bzl Outdated Show resolved Hide resolved
lib/private/utils.bzl Outdated Show resolved Hide resolved
@alexeagle alexeagle requested review from kormide and removed request for alexeagle September 26, 2023 18:30
… and COMMON_TEST_RULE_ATTRIBUTES to global constants.
lib/private/utils.bzl Outdated Show resolved Hide resolved
@reltuk
Copy link
Contributor Author

reltuk commented Sep 26, 2023

Thanks for the great feedback and support here so far everyone :).

@thesayyn thesayyn enabled auto-merge (squash) September 26, 2023 21:21
@thesayyn thesayyn merged commit a4e997d into aspect-build:main Sep 26, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants